Get rid of succ & fail marks on rate summary #3765
Conversation
|
This PR aligns with our goal and designs to refactor the end-of-test summary. As a matter of fact, we integrated its approach in our designs. From my perspective, this is good to go and merge, in principle 👍🏻 |
|
We (@oleiade and I, among others) have been discussing details like what's mentioned in #3765 (comment), and others covered in the design doc, like grouping metrics (http, network, execution, etc) and we agreed to merge this, as it already brings some value to those users that still nowadays are getting confused with the current format using ✓ and ✗ for rate metrics (see this example), and is compatible with changes that will come in the near future. So, we ship some value in the next/current release, and iterate later, instead of waiting till the end result to ship the value. Besides, I'm not adding the |
What?
It replaces the use of succ & fail marks (✓/✗) for rate metrics on summary, in favor of the text:
{success} out of {total}.Note: the check summary remains the same, as for checks there's no ambiguity on the use of ✓ and ✗.
Why?
Because as discussed in #2306 and #3656, the current form is sometimes confusing, because the metric may have either a "positive" meaning (like successful requests) or a "negative" meaning (like failed requests), for which the use of ✓ may result in confusions, especially for the latter.
Checklist
make lint) and all checks pass.make tests) and all tests pass.Related PR(s)/Issue(s)
Closes #2306
Second iteration of #3656, based on what was discussed there.